[web] Rebuild web interface

web-src/eslint.config.js

@@ -19,7 +19,6 @@ export default [
     rules: {
       camelcase: 'off',
       'consistent-this': 'off',
-      'default-param-last': 'off',
       'id-length': 'off',
       'max-lines': 'off',
       'max-lines-per-function': 'off',
@@ -32,15 +31,11 @@ export default [
       'no-shadow': 'off',
       'no-ternary': 'off',
       'no-undef': 'off',
-      'no-undefined': 'off',
-      'no-unused-expressions': 'off',
       'no-unused-vars': ['error', { args: 'none', caughtErrors: 'none' }],
       'no-useless-assignment': 'off',
       'one-var': 'off',
-      'prefer-destructuring': 'off',
       'prefer-named-capture-group': 'off',
       'sort-keys': 'off',
-      'sort-vars': 'off',
       'vue/html-self-closing': 'off',
       'vue/max-attributes-per-line': 'off',
       'vue/prop-name-casing': 'off',

web-src/src/App.vue

@@ -144,19 +144,15 @@ export default {
         protocol = 'wss://'
       }
 
-      let wsUrl = `${protocol + window.location.hostname}:${
-        this.$store.state.config.websocket_port
-      }`
+      let wsUrl = `${protocol}${window.location.hostname}:${this.$store.state.config.websocket_port}`
 
       if (import.meta.env.DEV && import.meta.env.VITE_OWNTONE_URL) {
         /*
          * If we are running in development mode, construct the websocket
          * url from the host of the environment variable VITE_OWNTONE_URL
          */
-        const owntoneUrl = new URL(import.meta.env.VITE_OWNTONE_URL)
-        wsUrl = `${protocol + owntoneUrl.hostname}:${
-          this.$store.state.config.websocket_port
-        }`
+        const url = new URL(import.meta.env.VITE_OWNTONE_URL)
+        wsUrl = `${protocol}${url.hostname}:${this.$store.state.config.websocket_port}`
       }
 
       const socket = new ReconnectingWebSocket(wsUrl, 'notify', {

web-src/src/components/CoverArtwork.vue

@@ -1,6 +1,6 @@
 <template>
   <figure>
-    <img v-lazy="{ src: artwork_url, lifecycle }" @click="$emit('click')" />
+    <img v-lazy="{ src: url, lifecycle }" @click="$emit('click')" />
   </figure>
 </template>
 
@@ -12,7 +12,7 @@ export default {
   props: {
     album: { default: '', type: String },
     artist: { default: '', type: String },
-    artwork_url: { default: '', type: String }
+    url: { default: '', type: String }
   },
   emits: ['click'],
 

web-src/src/components/ListAlbums.vue

@@ -10,7 +10,7 @@
     <div v-else class="media is-align-items-center" @click="open(item.item)">
       <div v-if="show_artwork" class="media-left">
         <cover-artwork
-          :artwork_url="item.item.artwork_url"
+          :url="item.item.artwork_url"
           :artist="item.item.artist"
           :album="item.item.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-small-image"
@@ -47,6 +47,7 @@
       @play-count-changed="play_count_changed()"
     />
     <modal-dialog
+      :close_action="$t('page.podcast.cancel')"
       :delete_action="$t('page.podcast.remove')"
       :show="show_remove_podcast_modal"
       :title="$t('page.podcast.remove-podcast')"
@@ -120,7 +121,7 @@ export default {
     },
     open_remove_podcast_dialog() {
       webapi
-        .library_album_tracks(this.selected_album.id, { limit: 1 })
+        .library_album_tracks(this.selected_item.id, { limit: 1 })
         .then(({ data }) => {
           webapi.library_track_playlists(data.items[0].id).then(({ data }) => {
             ;[this.rss_playlist_to_remove] = data.items.filter(

web-src/src/components/ListAlbumsSpotify.vue

@@ -3,7 +3,7 @@
     <div class="media is-align-items-center" @click="open(item)">
       <div v-if="show_artwork" class="media-left is-clickable">
         <cover-artwork
-          :artwork_url="artwork_url(item)"
+          :url="artwork_url(item)"
           :artist="item.artist"
           :album="item.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-small-image"

web-src/src/components/LyricsPane.vue

@@ -129,9 +129,11 @@ export default {
           ) {
             return index
           }
-          currentVerse.time < currentTime
-            ? (start = index + 1)
-            : (end = index - 1)
+          if (currentVerse.time < currentTime) {
+            start = index + 1
+          } else {
+            end = index - 1
+          }
         }
         return -1
       }
@@ -141,7 +143,9 @@ export default {
   },
   watch: {
     verse_index() {
-      this.autoScrolling && this.scroll_to_verse()
+      if (this.autoScrolling) {
+        this.scroll_to_verse()
+      }
       this.lastIndex = this.verse_index
     }
   },

web-src/src/components/ModalDialog.vue

@@ -45,7 +45,7 @@
 export default {
   name: 'ModalDialog',
   props: {
-    close_action: { default: 'dialog.cancel', type: String },
+    close_action: { default: '', type: String },
     delete_action: { default: '', type: String },
     ok_action: { default: '', type: String },
     show: Boolean,

web-src/src/components/ModalDialogAlbum.vue

@@ -6,7 +6,7 @@
         <div class="card">
           <div class="card-content">
             <cover-artwork
-              :artwork_url="item.artwork_url"
+              :url="item.artwork_url"
               :artist="item.artist"
               :album="item.name"
               class="fd-has-shadow fd-cover fd-cover-normal-image mb-5"

web-src/src/components/ModalDialogAlbumSpotify.vue

@@ -6,7 +6,7 @@
         <div class="card">
           <div class="card-content">
             <cover-artwork
-              :artwork_url="artwork_url(item)"
+              :url="artwork_url(item)"
               :artist="item.artist"
               :album="item.name"
               class="fd-has-shadow fd-cover fd-cover-normal-image mb-5"

web-src/src/i18n/de.json

@@ -8,7 +8,6 @@
     }
   },
   "dialog": {
-    "cancel": "Abbrechen",
     "add": {
       "rss": {
         "add": "Hinzufügen",
@@ -385,6 +384,7 @@
       "count": "{count} Playlist|{count} Playlisten"
     },
     "podcast": {
+      "cancel": "Abbrechen",
       "play": "Spielen",
       "remove": "Entfernen",
       "remove-info-1": "Diesen Podcast wirklich dauerhaft aus der Bibliothek löschen?",

web-src/src/i18n/en.json

@@ -8,7 +8,6 @@
     }
   },
   "dialog": {
-    "cancel": "Cancel",
     "add": {
       "rss": {
         "add": "Add",
@@ -385,6 +384,7 @@
       "count": "{count} playlist|{count} playlist|{count} playlists"
     },
     "podcast": {
+      "cancel": "Cancel",
       "play": "Play",
       "remove": "Remove",
       "remove-info-1": "Permanently remove this podcast from your library?",

web-src/src/i18n/fr.json

@@ -8,7 +8,6 @@
     }
   },
   "dialog": {
-    "cancel": "Annuler",
     "add": {
       "rss": {
         "add": "Ajouter",
@@ -385,6 +384,7 @@
       "count": "{count} liste de lecture|{count} liste de lecture|{count} listes de lecture"
     },
     "podcast": {
+      "cancel": "Annuler",
       "play": "Lire",
       "remove": "Supprimer",
       "remove-info-1": "Supprimer ce podcast de manière permanente de la bibliothèque ?",

web-src/src/i18n/zh.json

@@ -8,7 +8,6 @@
     }
   },
   "dialog": {
-    "cancel": "取消",
     "add": {
       "rss": {
         "add": "添加",
@@ -385,6 +384,7 @@
       "count": "{count} 个播放列表|{count} 个播放列表"
     },
     "podcast": {
+      "cancel": "取消",
       "play": "播放",
       "remove": "移除",
       "remove-info-1": "从资料库中永久移除该播客？",

web-src/src/lib/GroupedList.js

@@ -50,7 +50,7 @@ const timeIndex = (string) => {
   return times.find((item) => isNaN(diff) || diff < item.difference)?.text(date)
 }
 
-const createIndexer = ({ field, type = undefined } = {}) => {
+const createIndexer = ({ field, type } = {}) => {
   switch (type) {
     case String:
       return (item) => characterIndex(item[field])
@@ -66,7 +66,10 @@ const createIndexer = ({ field, type = undefined } = {}) => {
 }
 
 export class GroupedList {
-  constructor({ items = [], total = 0, offset = 0, limit = -1 } = {}, options) {
+  constructor(
+    { items = [], total = 0, offset = 0, limit = -1 } = {},
+    options = {}
+  ) {
     this.items = items
     this.total = total
     this.offset = offset

web-src/src/pages/PageAlbum.vue

@@ -21,7 +21,7 @@
       </template>
       <template #heading-right>
         <cover-artwork
-          :artwork_url="album.artwork_url"
+          :url="album.artwork_url"
           :artist="album.artist"
           :album="album.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-medium-image"

web-src/src/pages/PageAlbumSpotify.vue

@@ -25,7 +25,7 @@
       </template>
       <template #heading-right>
         <cover-artwork
-          :artwork_url="artwork_url(album)"
+          :url="artwork_url(album)"
           :artist="album.artists[0].name"
           :album="album.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-medium-image"

web-src/src/pages/PageArtistSpotify.vue

@@ -71,11 +71,11 @@ const dataObject = {
   },
 
   set(vm, response) {
-    vm.artist = response[0]
+    vm.artist = response.shift()
     vm.albums = []
     vm.total = 0
     vm.offset = 0
-    vm.append_albums(response[1])
+    vm.append_albums(response.shift())
   }
 }
 

web-src/src/pages/PageAudiobooksAlbum.vue

@@ -21,7 +21,7 @@
       </template>
       <template #heading-right>
         <cover-artwork
-          :artwork_url="album.artwork_url"
+          :url="album.artwork_url"
           :artist="album.artist"
           :album="album.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-medium-image"

web-src/src/pages/PageGenreAlbums.vue

@@ -62,7 +62,7 @@ const dataObject = {
   },
 
   set(vm, response) {
-    vm.genre = response[0].data.genres.items[0]
+    vm.genre = response[0].data.genres.items.shift()
     vm.albums = new GroupedList(response[1].data.albums, {
       index: { field: 'name_sort', type: String }
     })

web-src/src/pages/PageGenreTracks.vue

@@ -73,7 +73,7 @@ const dataObject = {
   },
 
   set(vm, response) {
-    vm.genre = response[0].data.genres.items[0]
+    vm.genre = response[0].data.genres.items.shift()
     vm.tracks_list = new GroupedList(response[1].data.tracks)
   }
 }

web-src/src/pages/PageNowPlaying.vue

@@ -3,7 +3,7 @@
     <div v-if="track.id > 0" class="hero-body is-flex is-align-items-center">
       <div class="container has-text-centered" style="max-width: 500px">
         <cover-artwork
-          :artwork_url="track.artwork_url"
+          :url="track.artwork_url"
           :artist="track.artist"
           :album="track.album"
           class="is-clickable fd-has-shadow fd-cover-big-image"

web-src/src/pages/PagePlaylistTracksSpotify.vue

@@ -72,11 +72,11 @@ const dataObject = {
   },
 
   set(vm, response) {
-    vm.playlist = response[0]
+    vm.playlist = response.shift()
     vm.tracks = []
     vm.total = 0
     vm.offset = 0
-    vm.append_tracks(response[1])
+    vm.append_tracks(response.shift())
   }
 }
 

web-src/src/pages/PagePodcast.vue

@@ -19,7 +19,7 @@
       </template>
       <template #heading-right>
         <cover-artwork
-          :artwork_url="album.artwork_url"
+          :url="album.artwork_url"
           :artist="album.artist"
           :album="album.name"
           class="is-clickable fd-has-shadow fd-cover fd-cover-medium-image"
@@ -47,6 +47,7 @@
         <modal-dialog
           :show="show_remove_podcast_modal"
           :title="$t('page.podcast.remove-podcast')"
+          :close_action="$t('page.podcast.cancel')"
           :delete_action="$t('page.podcast.remove')"
           @close="show_remove_podcast_modal = false"
           @delete="remove_podcast"

web-src/src/pages/PageSearchLibrary.vue

@@ -190,12 +190,12 @@ export default {
       this.$store.dispatch('add_recent_search', this.search_query)
     },
     search_items(type) {
-      const music = type !== 'audiobook' && type !== 'podcast',
-        kind = music ? 'music' : type,
-        parameters = {
-          type: music ? type : 'album',
-          limit: this.search_limit
-        }
+      const music = type !== 'audiobook' && type !== 'podcast'
+      const kind = music ? 'music' : type
+      const parameters = {
+        limit: this.search_limit,
+        type: music ? type : 'album'
+      }
       if (this.search_query.startsWith('query:')) {
         parameters.expression = `(${this.search_query.replace(/^query:/u, '').trim()}) and media_kind is ${kind}`
       } else if (music) {

web-src/src/webapi/index.js

@@ -39,7 +39,7 @@ export default {
   },
 
   library_add(url) {
-    return axios.post('./api/library/add', undefined, { params: { url } })
+    return axios.post('./api/library/add', null, { params: { url } })
   },
 
   library_album(albumId) {
@@ -47,7 +47,7 @@ export default {
   },
 
   library_album_track_update(albumId, attributes) {
-    return axios.put(`./api/library/albums/${albumId}/tracks`, undefined, {
+    return axios.put(`./api/library/albums/${albumId}/tracks`, null, {
       params: attributes
     })
   },
@@ -151,7 +151,7 @@ export default {
   },
 
   library_playlist_delete(playlistId) {
-    return axios.delete(`./api/library/playlists/${playlistId}`, undefined)
+    return axios.delete(`./api/library/playlists/${playlistId}`, null)
   },
 
   library_playlist_folder(playlistId = 0) {
@@ -189,7 +189,7 @@ export default {
   },
 
   library_rescan(scan_kind) {
-    return axios.put('./api/rescan', undefined, { params: { scan_kind } })
+    return axios.put('./api/rescan', null, { params: { scan_kind } })
   },
 
   library_stats() {
@@ -205,13 +205,13 @@ export default {
   },
 
   library_track_update(trackId, attributes = {}) {
-    return axios.put(`./api/library/tracks/${trackId}`, undefined, {
+    return axios.put(`./api/library/tracks/${trackId}`, null, {
       params: attributes
     })
   },
 
   library_update(scan_kind) {
-    return axios.put('./api/update', undefined, { params: { scan_kind } })
+    return axios.put('./api/update', null, { params: { scan_kind } })
   },
 
   output_toggle(outputId) {
@@ -253,7 +253,7 @@ export default {
   },
 
   player_play(options = {}) {
-    return axios.put('./api/player/play', undefined, { params: options })
+    return axios.put('./api/player/play', null, { params: options })
   },
 
   player_play_expression(expression, shuffle, position) {
@@ -264,7 +264,7 @@ export default {
       playback_from_position: position,
       shuffle
     }
-    return axios.post('./api/queue/items/add', undefined, { params })
+    return axios.post('./api/queue/items/add', null, { params })
   },
 
   player_play_uri(uris, shuffle, position) {
@@ -275,7 +275,7 @@ export default {
       shuffle,
       uris
     }
-    return axios.post('./api/queue/items/add', undefined, { params })
+    return axios.post('./api/queue/items/add', null, { params })
   },
 
   player_previous() {
@@ -350,7 +350,7 @@ export default {
 
   queue_expression_add(expression) {
     return axios
-      .post('./api/queue/items/add', undefined, { params: { expression } })
+      .post('./api/queue/items/add', null, { params: { expression } })
       .then((response) => {
         store.dispatch('add_notification', {
           text: t('server.appended-tracks', {
@@ -371,7 +371,7 @@ export default {
       params.position = store.getters.now_playing.position + 1
     }
     return axios
-      .post('./api/queue/items/add', undefined, { params })
+      .post('./api/queue/items/add', null, { params })
       .then((response) => {
         store.dispatch('add_notification', {
           text: t('server.appended-tracks', {
@@ -394,7 +394,7 @@ export default {
 
   queue_save_playlist(name) {
     return axios
-      .post('./api/queue/save', undefined, { params: { name } })
+      .post('./api/queue/save', null, { params: { name } })
       .then((response) => {
         store.dispatch('add_notification', {
           text: t('server.queue-saved', { name }),